New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate spec groups #3965
Deduplicate spec groups #3965
Conversation
8a9d58a
to
610e9aa
Compare
610e9aa
to
c3fe786
Compare
@kou Would you mind having a look at this PR? Do you think it makes sense? I noticed all the duplicated spec groups which made debugging output much more verbose than it should (I think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
It makes sense. Sorry for this duplication!
No problem at all. Thanks for having a look at this and also for making bundler actually work with multiple platforms 😃. |
Deduplicate spec groups (cherry picked from commit b403496)
Deduplicate spec groups (cherry picked from commit b403496)
Deduplicate spec groups (cherry picked from commit b403496)
Deduplicate spec groups (cherry picked from commit b403496)
Deduplicate spec groups (cherry picked from commit b403496)
Deduplicate spec groups (cherry picked from commit b403496)
Description:
While debugging resolver issues, I noticed that in the recent bundler versions, spec groups show up as duplicated, like this:
Not sure if this has any influence in the resolution process, but it's certainly inconvenient for debugging and it didn't happen in previous versions.
With these changes, we get deduplicated groups again:
Tasks:
I will abide by the code of conduct.